Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move display package from oras client library to oras-go #774

Closed
Raikerian opened this issue Jun 10, 2024 · 3 comments
Closed

Move display package from oras client library to oras-go #774

Raikerian opened this issue Jun 10, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested stale Inactive issues or pull requests

Comments

@Raikerian
Copy link

Hi everyone.

I am currently working on a project where I have implemented a custom ORAS content store to handle file packaging according to my specific requirements. Due to this customization, I find it challenging to use the default commands provided by the ORAS client library, such as oras push, as there is no support for plugin or custom store injection in these commands.

While exploring the client library, I found many useful packages. One package that stands out for my current needs is the tracker/status functionality for objects being pushed or pulled, found here: https://github.com/oras-project/oras/tree/main/cmd/oras/internal/display

Proposal:
I believe it would be beneficial to have the push/pull tracker functionality decoupled from the CLI, making it accessible to users of the library who, like me, have custom content stores.

I am open to contributing to this effort if needed and would also appreciate any guidance or existing workarounds for using oras push with a custom store.

@shizhMSFT
Copy link
Contributor

Hi @Raikerian, we split oras into the oras CLI and the oras-go library as discussed in oras-project/oras#181 many years ago.

The purpose of the oras-go library is to only contain core functionalities with as few dependencies as possible. The oras-go library is supposed to be stable and suitable for all adopters.

On the other hand, the oras CLI has no such restrictions. It can have any necessary dependencies as it wants. However, oras CLI only maintains the semantic versioning for the CLI interface. In other words, packages in the oras CLI may change commit by commit.

Therefore, we will not consider moving the internal package display from the oras CLI to the oras-go library due to the above facts. Nonetheless, I would suggest forking the oras CLI to use a custom store.

@shizhMSFT shizhMSFT reopened this Jun 11, 2024
@shizhMSFT shizhMSFT added enhancement New feature or request question Further information is requested labels Jun 11, 2024
Copy link

This issue is stale because it has been open for 60 days with no activity. Remove the stale label or comment to prevent it from being closed in 30 days.

@github-actions github-actions bot added the stale Inactive issues or pull requests label Oct 14, 2024
Copy link

This issue has been closed because there has been no activity for 30 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested stale Inactive issues or pull requests
Projects
None yet
Development

No branches or pull requests

2 participants