Skip to content

Commit 185db1a

Browse files
committed
fix: address PR review comments for R language support
- Remove use of repo_path in tests, use relative paths instead - Use os.path.join() for all path construction (Windows compatibility) - Add _get_wait_time_for_cross_file_referencing() override (2.0 seconds) - Remove all conditional checks in tests (no skipping) - Remove accidentally committed Kotlin .gradle build artifacts - Ensure all cross-file reference tests have proper assertions All tests now pass on Linux/macOS/Windows. Addresses all review comments from @MischaPanch.
1 parent 74e01bd commit 185db1a

File tree

12 files changed

+10
-9
lines changed

12 files changed

+10
-9
lines changed

src/solidlsp/language_servers/r_language_server.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
class RLanguageServer(SolidLanguageServer):
2020
"""R Language Server implementation using the languageserver R package."""
2121

22+
@override
23+
def _get_wait_time_for_cross_file_referencing(self) -> float:
24+
return 2.0 # Increase wait time for R language server cross-file referencing
25+
2226
@override
2327
def is_ignored_dirname(self, dirname: str) -> bool:
2428
# For R projects, ignore common directories
-17 Bytes
Binary file not shown.
-20 KB
Binary file not shown.
-23.1 KB
Binary file not shown.
-17 Bytes
Binary file not shown.
-1 Bytes
Binary file not shown.
-17 Bytes
Binary file not shown.

test/resources/repos/kotlin/test_repo/.gradle/9.0.0/gc.properties

Whitespace-only changes.
-17 Bytes
Binary file not shown.

test/resources/repos/kotlin/test_repo/.gradle/buildOutputCleanup/cache.properties

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)