History based reindex vs. git revert #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ginoaugustine
approved these changes
Aug 1, 2024
vladak
force-pushed
the
history_based_reindex_vs_git_revert
branch
from
5e56a41 to
1fbc4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing incremental reindex in the face of sequence of changes to a file that in the end nullify each other by checking the last modified date of the file to the date stored in the corresponding document. The first idea was to simply "
touch" the files however that would cause unneeded churn.While there, the changes to the
IndexDatabaseTestsomehow made the Windows builds failing due to pending references to index files (withAccessDeniedexception thrown fromIOutils.removeRecursive()), also even in different test classes due to the intertwined nature of indexing andRuntimeEnvironment. Hence the index searcher related changes.