Skip to content

Commit 1768796

Browse files
committed
Update testbed for tools_enabled
1 parent a32b10b commit 1768796

File tree

2 files changed

+21
-12
lines changed

2 files changed

+21
-12
lines changed

src/client/content/config/tabs/settings.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -363,17 +363,21 @@ def spring_ai_conf_check(ll_model: dict, embed_model: dict) -> str:
363363
def spring_ai_obaas(src_dir, file_name, provider, ll_config, embed_config):
364364
"""Get the system prompt for SpringAI export"""
365365

366+
## FUTURE FEATURE:
366367
# Determine which system prompt would be active based on tools_enabled
367-
tools_enabled = state.client_settings.get("tools_enabled", [])
368+
# tools_enabled = state.client_settings.get("tools_enabled", [])
368369

369370
# Select prompt name based on tools configuration
370-
if not tools_enabled:
371-
prompt_name = "optimizer_basic-default"
372-
if state.client_settings["vector_search"]["enabled"]:
373-
prompt_name = "optimizer_vs-no-tools-default"
374-
else:
375-
# Tools are enabled, use tools-default prompt
376-
prompt_name = "optimizer_tools-default"
371+
# if not tools_enabled:
372+
# prompt_name = "optimizer_basic-default"
373+
# if state.client_settings["vector_search"]["enabled"]:
374+
# prompt_name = "optimizer_vs-no-tools-default"
375+
# else:
376+
# # Tools are enabled, use tools-default prompt
377+
# prompt_name = "optimizer_tools-default"
378+
## Legacy Feature:
379+
if "Vector Search" in state.client_settings["tools_enabled"]:
380+
prompt_name = "optimizer_vs-no-tools-default"
377381

378382
# Find the prompt in configs
379383
sys_prompt_obj = next((item for item in state.prompt_configs if item["name"] == prompt_name), None)

src/client/content/testbed.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,12 @@ def create_gauge(value):
8585
st.dataframe(ll_settings_reversed, hide_index=True)
8686
if report["settings"]["testbed"]["judge_model"]:
8787
st.markdown(f"**Judge Model**: {report['settings']['testbed']['judge_model']}")
88-
# if discovery; then list out the tables that were discovered (MCP implementation)
89-
# if report["settings"]["vector_search"].get("discovery"):
90-
if report["settings"]["vector_search"]["enabled"]:
88+
# Backward compatibility
89+
try:
90+
vs_enabled = report["settings"]["vector_search"]["enabled"]
91+
except KeyError:
92+
vs_enabled = "Vector Search" in report["settings"]["tools_enabled"]
93+
if vs_enabled:
9194
st.subheader("Vector Search Settings")
9295
st.markdown(f"""**Database**: {report["settings"]["database"]["alias"]};
9396
**Vector Store**: {report["settings"]["vector_search"]["vector_store"]}
@@ -100,6 +103,8 @@ def create_gauge(value):
100103
if report["settings"]["vector_search"]["search_type"] == "Similarity":
101104
embed_settings.drop(["score_threshold", "fetch_k", "lambda_mult"], axis=1, inplace=True)
102105
st.dataframe(embed_settings, hide_index=True)
106+
# if discovery; then list out the tables that were discovered (MCP implementation)
107+
# if report["settings"]["vector_search"].get("discovery"):
103108
else:
104109
st.markdown("**Evaluated without Vector Search**")
105110

@@ -516,7 +521,7 @@ def render_evaluation_ui(available_ll_models: list) -> None:
516521
key="evaluate_button",
517522
help="Evaluation will automatically save the TestSet to the Database",
518523
on_click=qa_update_db,
519-
disabled=not state.enable_client,
524+
disabled=not state.get("enable_client", True),
520525
):
521526
with st.spinner("Starting Q&A evaluation... please be patient.", show_time=True):
522527
st_common.clear_state_key("testbed_evaluations")

0 commit comments

Comments
 (0)