Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log 404 errors #98

Open
reenjii opened this issue Mar 9, 2022 · 1 comment · May be fixed by #99
Open

Do not log 404 errors #98

reenjii opened this issue Mar 9, 2022 · 1 comment · May be fixed by #99

Comments

@reenjii
Copy link

reenjii commented Mar 9, 2022

Hello,

I have a workflow where I try to get an OpsGenie alert by alias to check existence and close it if needed.
Whenever I get an alert that does not exist on OpsGenie, SDK logs an error-level message on API 404 error.
This creates many error-level logs on my application despite everything working as expected.

Here is the culprit: https://github.com/opsgenie/opsgenie-go-sdk-v2/blob/master/client/client.go#L475

I want to remove this log because it is not an actual API error, and leave it to the caller to decide to log this information.

Thanks

@reenjii reenjii linked a pull request Mar 9, 2022 that will close this issue
@snigle
Copy link

snigle commented May 23, 2022

up ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants