Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode + in e-mail addr (Team Member API) #62

Open
arnisoph opened this issue Aug 13, 2020 · 1 comment
Open

Encode + in e-mail addr (Team Member API) #62

arnisoph opened this issue Aug 13, 2020 · 1 comment

Comments

@arnisoph
Copy link

As of https://docs.opsgenie.com/docs/opsgenie-go-api-v2#samples-for-team-member-sdk the user (dev) should encode the plus char in e-mail addr. I propose doing it in the SDK here. Are there any reasons why it's not solved in the go sdk already? The sdk is taking care of all the REST HTTP actions anyway?

If you use MemberIdentifierType as "username" and your username includes "+" character, you need to encode "+" as "%2B".

@arnisoph
Copy link
Author

arnisoph commented Aug 13, 2020

hmm I have to admit, I don't get an error when using an addr containing + but not manually encoding it. Is the warning in the docs still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant