Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context is not actually passed to http request #126

Open
ajduffield opened this issue Mar 23, 2023 · 2 comments
Open

Context is not actually passed to http request #126

ajduffield opened this issue Mar 23, 2023 · 2 comments

Comments

@ajduffield
Copy link

In the client exec function line 465: https://github.com/opsgenie/opsgenie-go-sdk-v2/blob/master/client/client.go#L465 the req.WithContext returns a new Request object with the context, instead of editing the Request object. This returned object needs to be assigned back to the request object of the client.
@ajduffield
Copy link
Author

Submitted PR: #125 to fix

@ajduffield ajduffield mentioned this issue Mar 23, 2023
Open
@smitthakkar96
Copy link

Hello team,

Are there any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smitthakkar96 @ajduffield