-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the query API #28
Comments
I suppose that specifically, you are asking to flesh out StackdriverStorageComponent to include the read-back (query) api. |
It would be nice for us to be able to support the entire Zipkin API, however there's a bit of a challenge with translating between the Zipkin and Stackdriver data models for supporting the query API. In order to work correctly with Stackdriver's single-host spans, we currently split Zipkin multi-host spans into multiple Stackdriver single-host spans by rewriting some of the Zipkin span ID's. If we want the read and write API's to be symmetric, we'd likely need to store additional information (such as the original Zipkin ID) in the Stackdriver Trace in order to be able to perform the inverse operation when reading Zipkin traces. Another alternative would be to not do any advanced translation on the read API and always return single-host Zipkin spans. This would make read and write asymmetric, but would be simpler to implement. @adriancole Any thoughts? In the meantime, you can also list Traces by using the Stackdriver Trace API directly, however this uses the Stackdriver data model, not the Zipkin data model: https://cloud.google.com/trace/api/reference/rest/v1/projects.traces/list |
starting with simple readbacks is probably best (even if asymetric) For example, it would progress things. We'd eventually need to address some translation/folding, but at worst case that could be localized in a test support class. |
Any luck with this? :P |
Not yet, but pull requests are welcome! |
Readback isn't supported, yet. See openzipkin/zipkin-gcp#28
Hello All, |
Hi! It would be really nice for the collector to provide the query API. Without this it's difficult to programmatically verify whether the stackdriver has received the spans properly.
In Sleuth I'm writing end to end tests (https://github.com/marcingrzejszczak/stackdriver-e2e) that are starting the collector, 2 applications and then are checking if after curling a request to one of them the Stackdriver has a proper trace in it. I wanted to do the query via a collector but there's no query api available since the span store in the stackdriver Zipkin collector doesn't allow reads.
Related issue - spring-cloud/spring-cloud-sleuth#493
The text was updated successfully, but these errors were encountered: