Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Finagle 22.7.0 and 22.12.0 #131

Open
bpholt opened this issue Feb 15, 2023 · 1 comment
Open

Release for Finagle 22.7.0 and 22.12.0 #131

bpholt opened this issue Feb 15, 2023 · 1 comment

Comments

@bpholt
Copy link

bpholt commented Feb 15, 2023

Feature

Please release versions of zipkin-finagle compiled with Finagle 22.7.0 and 22.12.0

Rationale

When running zipkin-finagle-http (compiled against Finagle 22.4.0) with Finagle 22.7.0, we see errors like

java.lang.AbstractMethodError: Missing implementation of resolved method 'abstract com.twitter.finagle.Status status()' of abstract class com.twitter.finagle.ServiceFactory.

due to twitter/finagle@b2a7f4e.

@bpholt
Copy link
Author

bpholt commented Feb 15, 2023

Finagle 22.7.0 was merged in #116, so I'm hopeful it would be straightforward to release that without further changes.

Finagle 22.12.0 hasn't been merged yet. Its PR is #123, and it looks like it's failing in CI, so that would have to be resolved, but I don't think that would stop releasing 22.7.0 at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant