Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edge-case behavior nice for elasticsearch service on AWS #142

Open
codefromthecrypt opened this issue Sep 23, 2016 · 2 comments
Open

Make edge-case behavior nice for elasticsearch service on AWS #142

codefromthecrypt opened this issue Sep 23, 2016 · 2 comments

Comments

@codefromthecrypt
Copy link
Member

@devinsba noticed the error handling wasn't right when his account was missing permissions for elasticsearch. We should note in the readme (well create a readme first and note) the IAM permissions needed. Let's add a error nicer than NPE when it isn't there.

There was also a report of a hang on a newly provisioned cluster. This might be a smell of an infinite socket or otherwise timeout. Something to look into.

cc @sethp-jive
@codefromthecrypt
Copy link
Member Author

going to raise a pull request to fix something I messed up, more importantly carving out a unit test as doing the first one is usually the hard part.

codefromthecrypt referenced this issue in openzipkin/zipkin Sep 24, 2016
Fixes thread safety issues and improves health checks on elasticsearch
e6ba62a 
This fixes a thread-safety concern raised by @sethp-jive on AWS signing.

It also improves health check by not wrapping exceptions. This will
allow users to troubleshoot the system easier.

Finally, this throws on misconfigured credentials vs swallowing the
exception. This will help people use health checks also, as it makes
this configuration error visible without enabling debug logging.

See #1310
@codefromthecrypt codefromthecrypt transferred this issue from openzipkin/zipkin Aug 26, 2019
@codefromthecrypt
Copy link
Member Author

not sure if this is a problem still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt