Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose http builder for Apache http5 implementation #1443

Open
gmellemstrand opened this issue Sep 11, 2024 · 0 comments
Open

Expose http builder for Apache http5 implementation #1443

gmellemstrand opened this issue Sep 11, 2024 · 0 comments

Comments

@gmellemstrand
Copy link

Feature

With the addition of the brave.httpclient5 package all the handling of the builder object is done internally, and the only option is to call the build method and get the finished client object. This happens in the HttpClient5Tracing class.

Rationale

There can be many cases, when integrating with other libraries, where you want to add other options to the http builder besides what is being added by Brave. This option was also available in the http4 implementation, but was not added to the http5 implementation. Adding a new public method for this is a minimal change.

Example Scenario

In our case we are in the process of upgrading dropwizard-zipkin to Dropwizard 3, which requires the use of Apache http5 (and in turn the Brave http5 implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant