Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local correlation fields not logged #1376

Open
grassehh opened this issue Jul 11, 2023 · 0 comments
Open

Local correlation fields not logged #1376

grassehh opened this issue Jul 11, 2023 · 0 comments
Labels

Comments

@grassehh
Copy link

Describe the Bug

Hello, as I understand and as explained in Micrometer Tracing, correlation fields should be logged in the tracing context (i.e SFL4J MDC).

The issue is that using brave implementation requires them to be defined as remote fields in order to be logged in the MDC.

Steps to Reproduce

  • Clone this project
  • Checkout issues/brave branch
  • Start the app and call the server as explained in the README

You will see that only the standard traceId and spanId baggages are logged.
If you edit the application.yaml file and uncomment the following configuration:

      remote-fields:
        - myBaggageFilter
        - myBaggageController

The custom baggages myBaggageFilterand myBaggageController are now correctly logged.

Expected Behaviour

The custom baggages myBaggageFilterand myBaggageController should be logged without being declared as remote fields.

Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant