Skip to content
This repository was archived by the owner on Nov 27, 2017. It is now read-only.

Better rendering for spans with only client-side annotations #13

Open
mjbryant opened this issue Oct 4, 2016 · 1 comment
Open

Better rendering for spans with only client-side annotations #13

mjbryant opened this issue Oct 4, 2016 · 1 comment

Comments

@mjbryant
Copy link

mjbryant commented Oct 4, 2016

This is awesome, thanks for the work! I used this to visualize some of our internal data and noticed that the span display isn't so helpful when server spans are missing. Specifically, they display like this:

commit

It would be nice if the horizontal position was preserved when only client spans were present. Maybe the whole span could be a gray bar, just correctly positioned horizontally?

@mjbryant mjbryant changed the title Better rendering for spans with on client-side annotations Better rendering for spans with only client-side annotations Oct 4, 2016
@rogeralsing
Copy link
Contributor

Ah, yes, I will take a look at that, the code currenty calculates deltas between CS and SR, but ofc in this case it should just get the start and end of CS CR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants