Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to functions that defines GitHub Organization / GitHub User instead of creating fork for GHE #43

Open
larnsce opened this issue Nov 27, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@larnsce
Copy link
Contributor

larnsce commented Nov 27, 2024

@bonschorno, related to Global-Health-Engineering/waste-soil-composting-cape-maclear#1 and working towards using washr for GHE and more generally for anyone, I have realized that it would be better if we included the process of defining "the publisher" in a function rather than creating a fork to replace a few terms.

For the next development cycle (i.e. v.1.1.0 on 01.02.2025) I believe this is the most important feature.

@larnsce
Copy link
Contributor Author

larnsce commented Dec 2, 2024

@bonschorno @yashdubey132: I am still thinking about this. Last week I realized that we can start the entire workflow using:

  • Create empty repo on GitHub with package name
  • Clone repo
  • Use devtools::create(".") in root folder to turn into data package.

This will allow us to remove the step from the publishing guide where people need to use the terminal to connect the local and remote repository.

For the feature described in the title of this issue, I am thinking of doing the following:

  • Instead of "hardcoding" the name of a organization/user and repo into our templates, could we pull this information from the package itself? For example: I create a data package on my larnsce account and name it fskampala. Any function that produces a template which currently is openwashdata.github.io/datapackage should have placeholders, so that the template is populated with larnsce.github.io/fskampala.

Who can check if that's feasible?

@yashdubey132
Copy link

I can check the feasibility of this one

@yashdubey132 yashdubey132 self-assigned this Dec 5, 2024
@yashdubey132 yashdubey132 added the enhancement New feature or request label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants