You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Missing step for adding data to data-raw. The user need to know that they have to add their data to this folder and then use the data_processing.R script to prepare it. The descriptions here are not sufficient.
Under "communicate dataset" it is not cleat that build_readme() is from devtools and not from washr. Make it explicit with devtools::build_readme()
The Get started page is currently not useful for someone discovering and wanting to use this package. It needs the whole guide for it to make sense, including all sub-steps of working with the description, updating the dictionary, etc.
I understand that you tried to list the most crucial steps, but it created too much confusion at the moment. I would rather remove that Get Started page, update the data publishing guide to reflect openwashdata users as the target audience and then link to the guide.
data_processing.R Skript
Script uses data_in as the object name for reading data. Under the "Tidy data" section, there needs to be at least the step of whatawaste <- data_in, so that if no cleaning is required, the script runs through without an error. That would assume that the data resource has the same name as the data package. Both the guide and the Get Started page need more detailed information about naming the objects.
First release:
usethis::use_news_md()
usethis::use_cran_comments()
Title:
andDescription:
@return
and@examples
Authors@R:
includes a copyright holder (role 'cph')Prepare for release:
git pull
usethis::use_github_links()
urlchecker::url_check()
devtools::build_readme()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
git push
Submit to CRAN:
usethis::use_version('major')
devtools::submit_cran()
Wait for CRAN...
usethis::use_github_release()
usethis::use_dev_version(push = TRUE)
usethis::use_news_md()
The text was updated successfully, but these errors were encountered: