Skip to content

Wrong comment in SHA-crypt and derived code #5951

@solardiz

Description

@solardiz

There should be only one of these per file. Where we have two, the second one is wrong (the code that follows does something else):

./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sha512crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./ztex/fpga-sha512crypt/sha512crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./ztex/fpga-sha256crypt/sha256crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./sha256crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12512hash_fmt_plug.c:		/* For every character in the password add the entire password.  */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */

This was also reported in besser82/libxcrypt#222

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions