Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchFX][Optimization] Run eliminate dead code once for constant correction commands #2929

Open
1 task
daniil-lyakhov opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@daniil-lyakhov
Copy link
Collaborator

daniil-lyakhov commented Aug 29, 2024

🚀 Feature request

https://github.com/openvinotoolkit/nncf/pull/2882/files#r1735077003

  • Look like eliminate_dead_code should be run ones after apply all bias_update transormation.
    Or maybe will be better to use something like self.erase_node(old_constant_node) to remove only old constant node to avoid loops for all nodes.
    As i understand eliminate_dead_code here removes only old constant node. And it's actual for all usage eliminate_dead_code in transformation.py.

  • We can do it, but we should give up on transformations and move to commands for that. Leaf insertion transformation not expecting eliminate_dead_code call yet model transformer could not split bias correction and leaf insertion commands apart

Feature Use Case

No response

Are you going to submit a PR?

  • Yes I'd like to help by submitting a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant