Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Answer question of directionality #1105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Answer question of directionality #1105

wants to merge 1 commit into from

Conversation

gfellerph
Copy link
Collaborator

Closes #1098 which resolved to make the switch adapt to flow direction of scripts and render the "on" state on the left side for rtl and on the right side for ltr.

@gfellerph
Answer question of directionality
525de50 
Issue #1098 resolved to make the switch adapt to flow direction of scripts and render the "on" state on the left side for `rtl` and on the right side for `ltr`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregwhitworth gregwhitworth Awaiting requested review from gregwhitworth gregwhitworth is a code owner

@mfreed7 mfreed7 Awaiting requested review from mfreed7 mfreed7 is a code owner

@dbaron dbaron Awaiting requested review from dbaron dbaron is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[switch]: Does the "on" position change between rtl and ltr?
1 participant
@gfellerph