Move html from javascript to views

[gravitystorm]

We have an amount of html building being created using JavaScript code. For example, in leaflet.share.js there is a substantial amount of html construction:

openstreetmap-website/app/assets/javascripts/leaflet.share.js

Lines 37 to 53 in 7cf9bf0

	$("<div class='btn-group btn-group-sm mb-2'>")
	.appendTo($form)
	.append($("<a class='btn btn-primary'>")
	.addClass("active")
	.attr("for", "long_input")
	.attr("id", "long_link")
	.text(I18n.t("javascripts.share.long_link")))
	.append($("<a class='btn btn-primary'>")
	.attr("for", "short_input")
	.attr("id", "short_link")
	.text(I18n.t("javascripts.share.short_link")))
	.append($("<a class='btn btn-primary'>")
	.attr("for", "embed_html")
	.attr("id", "embed_link")
	.attr("data-bs-title", I18n.t("javascripts.site.embed_html_disabled"))
	.attr("href", "#")
	.text(I18n.t("javascripts.share.embed")))

This makes it harder to find, and much harder to maintain, than having the html in a view like the rest of the site. It's also mostly unnecessary, since html like this isn't dynamic, it's the same for every user.

We should move all of this html into views, and use the javascript only for interactivity like changing content (e.g. taking results of an ajax query and putting them into the html) or to show/hide certain elements after UI interactions.

[Satya900]

Please assign me this issue i would like to work on it

[HolgerJeromin]

@Satya900 We do not work with assigns. Just go ahead! :)

[AntonKhorev]

For example, in leaflet.share.js there is a substantial amount of html construction: ...

Was done in https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-2b34a8a6e260ed3c05d38b8250e07e05617d32985d2250826373e7c2bce40d8f.

Was ignored by everyone.

[gravitystorm]

Was ignored by everyone.

That PR is marked as a draft, so I haven't reviewed it.