Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation member role comboboxes are not displaying available options when selected #10481

Open
nathanadams-tomtom opened this issue Sep 30, 2024 · 0 comments
Labels
bug A bug - let's fix this!

Comments

@nathanadams-tomtom
Copy link

URL

https://www.openstreetmap.org/edit#map=20/42.3609187/-71.0557088

How to reproduce the issue?

Steps to replicate the issue:

  1. Find or create a relation of a type for which options are provided by the taginfo service (e.g., a restriction: no left turn)
  2. Choose a feature that is part of the relation
  3. Select the relation in the relations section of the feature editor
  4. Click a member's role combobox

Screenshot(s) or anything else?

Depending on the relation, member role options are provided by the taginfo service with relevant choices when selecting member role combobox for a given relation. However, these options are not being displayed, leaving users with a combobox that functions as a text field.

A taginfo service request is triggered upon clicking a member role combobox (raw member editor), and a valid response is received, but the options are not displayed. The member role combobox for the same member, displayed in the relations section (raw membership editor) of the feature editor, shows available options when selected.

It appears the issue is caused when the mousedown event of a click on the member role input element bubbles to the member list item, which then triggers d3-drag handling, subsequently preventing the mouseup event from firing. This prevents the role options from being displayed as a result of the combobox mouseup event not firing. Stopping event propagation at the member's input wrapper, or in the combobox mousedown event, prevents the issue by preventing the drag events from triggering.

Stopping event propagation at the input wrapper or combobox prevents member dragging using the combobox, but still enables users to use the member header/label for reordering.

The issue is observed in Firefox version 130.0.1 and Chrome version 129.0.6668.60 on Windows 11.

Current state: relation member role options not displayed:
OpenStreetMap_RelationMemberRoleOptionsNotDisplayed

Expected behavior (relation member role options displayed):
OpenStreetMap_RelationMemberRoleOptionsExpected

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.2

Which browsers are you seeing this problem on?

Chrome, Firefox

@k-yle k-yle added the bug A bug - let's fix this! label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants