Improvements to further stablise the manila-ganesha tests #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the manila-ganesha tests by checking that ceph is stable/healthy, and b) ensuring that after the restart of manila-ganesha, that it is stable/healthy.
The scp_opts don't seem to be able to quiet the scp: error for the certificate.
During manila-ganesha charm deployment sometimes zombie ceph mds clients will be left attached to ceph fs. This locks the ceph fs service and breaks the test (can't create a manila-share). The bug is annoying, from a test gate perspective, but clears itself after 5-10 minutes, and so isn't (it is currently understood) a production issue. This patch detects the ceph unhealthy condition and then forcibly evicts the ceph MDS clients which then allows the test to proceed. Related-Bug: https://bugs.launchpad.net/charm-manila-ganesha/+bug/2073498
|
Review that verifies this change: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/917334 Note that this will need to be forward cherry-picked to master. |
|
It's still WIP as I've realised that currently this patch will probably break other manila combinations that don't use ceph. I'll work up another patch to resolve that. |
This is so that manila *only* tests without ceph will not try to clean-up non-existant ceph units.
freyes
approved these changes
Jul 18, 2024
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Jul 18, 2024
This patch converts stable/2024.1 into a stable maintenance branch. It: - modifies .gitreview to point to stable/2024.1 - switches (test-)requirements*.txt -> (test-)requirements*.in for pip-compile usage. - creates (test-)requirements-py*.txt from *.in using pip-compile for the relevant python version. - Updates bundles to point to ceph/edge and 24.04/edge for ceph and OVN charms. - Adds build.lock file to the reactive charms. - Syncs charm-helpers for classic charms. - Locks requirements.txt from requirements.in for ops machine charms. - Locks charms.openstack, zaza, zaza-openstack-tests, charm-helpers to stable branches. func-test-pr: openstack-charmers/zaza-openstack-tests#1246 Change-Id: I71dcacdf727ca63ab2479565cb2b089bd41801ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the manila-ganesha tests by checking that ceph is
stable/healthy, and b) ensuring that after the restart of
manila-ganesha, that it is stable/healthy.