Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunbeam control plane only tests fail because no nova-compute #1281

Closed
gboutry opened this issue Oct 18, 2024 · 1 comment
Closed

Sunbeam control plane only tests fail because no nova-compute #1281

gboutry opened this issue Oct 18, 2024 · 1 comment

Comments

@gboutry
Copy link
Contributor

gboutry commented Oct 18, 2024

https://github.com/openstack-charmers/zaza-openstack-tests/blob/891761d631e200dff9ebbc8e97639c54ffc7d6f6/zaza/openstack/charm_tests/tempest/utils.py#L248C5-L248C9

This changed added a dynamic lookup on units nova-compute.

Sunbeam control plane tests deploy no nova-compute application.

Sunbeam deployment have an openstack-hypervisor and not a nova-compute unit.

This change seems tailored toward charmed openstack only

  File "/home/zuul/src/opendev.org/openstack/sunbeam-charms/.tox/func/lib/python3.12/site-packages/zaza/openstack/charm_tests/tempest/utils.py", line 248, in _add_nova_config
    ctxt['min_compute_nodes'] = len(model.get_units('nova-compute'))
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/sunbeam-charms/.tox/func/lib/python3.12/site-packages/zaza/__init__.py", line 224, in _wrapper
    return future.result(timeout)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/concurrent/futures/_base.py", line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/home/zuul/src/opendev.org/openstack/sunbeam-charms/.tox/func/lib/python3.12/site-packages/zaza/__init__.py", line 209, in _runner
    return await f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/sunbeam-charms/.tox/func/lib/python3.12/site-packages/zaza/model.py", line 741, in async_get_units
    return model.applications[application_name].units
           ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
KeyError: 'nova-compute'
@gboutry
Copy link
Contributor Author

gboutry commented Oct 18, 2024

Fixed #1282

@gboutry gboutry closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant