From f16c0ed13dd0c8cd014dfd69719fa557b9b0dcc0 Mon Sep 17 00:00:00 2001
From: Nicholas Njihia <nicholas.njihia@canonical.com>
Date: Wed, 22 Sep 2021 17:15:48 +0300
Subject: [PATCH] Add LBaaSv2 volume-based Amphora test

Enable Amphora to run instances booted from a volume by flipping the
config option `enable-volume-based-amphora` to True and checking volumes
attached to the amphora instances.

Depends-On: https://review.opendev.org/c/openstack/charm-octavia/+/810567
Related-Bug: https://launchpad.net/bugs/1901732
---
 zaza/openstack/charm_tests/octavia/tests.py | 61 +++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/zaza/openstack/charm_tests/octavia/tests.py b/zaza/openstack/charm_tests/octavia/tests.py
index 3899d75c6..2aa607dfc 100644
--- a/zaza/openstack/charm_tests/octavia/tests.py
+++ b/zaza/openstack/charm_tests/octavia/tests.py
@@ -14,6 +14,7 @@
 
 """Encapsulate octavia testing."""
 
+import json
 import logging
 import subprocess
 import tenacity
@@ -34,6 +35,7 @@
     LoadBalancerUnexpectedState,
     LoadBalancerUnrecoverableError,
 )
+from zaza.openstack.utilities.os_versions import CompareOpenStack
 
 LBAAS_ADMIN_ROLE = 'load-balancer_admin'
 
@@ -534,3 +536,62 @@ class OctaviaTempestTestK8S(tempest_tests.TempestTestScaleK8SBase):
     """Test octavia k8s scale out and scale back."""
 
     application_name = "octavia"
+
+
+class VolumeBasedAmphoraTest(LBAASv2Test):
+    """LBaaSv2 Volume-based Amphora tests."""
+
+    @classmethod
+    def setUpClass(cls):
+        """Run class setup for LBaaSv2 Volume-based amphora tests."""
+        super(VolumeBasedAmphoraTest, cls).setUpClass()
+        os_versions = openstack_utils.get_current_os_versions(['octavia'])
+        if CompareOpenStack(os_versions['octavia']) < 'ussuri':
+            cls.skipTest('Run only for Openstack Ussuri and newer releases.')
+            return
+
+    def test_volume_based_amphora(self):
+        """Set up volume-based amphora."""
+        default_charm_config = {'enable-volume-based-amphora': False}
+        alternate_charm_config = {'enable-volume-based-amphora': True}
+        with self.config_change(default_charm_config,
+             alternate_charm_config, reset_to_charm_default=True):
+            logging.info("Enabled volume based amphora setting.")
+
+            vols_before = self.cinder_client.volumes.list()
+            # There may be some vms incl. amphora vms from prev tests so we
+            # need to ensure we create a new one to get one with volumes
+            # attached.
+            self.test_create_loadbalancer()
+
+            retries = 0
+            while True:
+                if retries > 10:
+                    raise Exception("number of volumes did not increase as "
+                                    "expected after creating amphora vm")
+
+                vols_after = self.cinder_client.volumes.list()
+                if len(vols_after) > len(vols_before):
+                    break
+
+                retries += 1
+
+            amphora_list = self.octavia_client.amphora_list()
+            self.assertTrue(len(amphora_list) > 0)
+            attached_volumes = []
+            for amphora in amphora_list.get('amphorae', []):
+                for server in self.nova_client.servers.list():
+                    if 'compute_id' in amphora and server.id == amphora[
+                       'compute_id']:
+                        server_id = amphora['compute_id']
+                        attached_volumes.append(json.dumps(vars(
+                            self.nova_client.volumes.get_server_volumes(
+                                server_id)))
+                        )
+            self.assertTrue(len(attached_volumes) > 0)
+            logging.info("Amphora volumes creation successful: {}",
+                         attached_volumes)
+
+    def test_create_loadbalancer(self):
+        """Create load balancer."""
+        super().test_create_loadbalancer()