Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop enabling afterburn-hostname.service on GCP #1432

Open
jlebon opened this issue Jan 26, 2024 · 4 comments
Open

Stop enabling afterburn-hostname.service on GCP #1432

jlebon opened this issue Jan 26, 2024 · 4 comments

Comments

@jlebon
Copy link
Member

jlebon commented Jan 26, 2024

Right now, RHCOS is carrying a patch for Afterburn to have it write to /etc/hostname (basically coreos/afterburn#512).

There's a lot of backstory on this also in coreos/afterburn#509. But IIUC, now that NM correctly shortens DHCP hostnames that are too long, we can rely on hostname setting via DHCP again and stop carrying that patch.

A big change here of course is that we'd no longer physically write /etc/hostname from the initramfs. Need to verify this doesn't break things. (Though presumably this works in OKD + FCOS today, where we don't have that patch.)

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2024
@jlebon
Copy link
Member Author

jlebon commented May 3, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2024
@jlebon
Copy link
Member Author

jlebon commented Aug 7, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants