Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unstable BWC CI action for 2.x branch #981

Open
martin-gaievski opened this issue Nov 8, 2024 · 3 comments
Open

[BUG] Unstable BWC CI action for 2.x branch #981

martin-gaievski opened this issue Nov 8, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Infrastructure

Comments

@martin-gaievski
Copy link
Member

What is the bug?

It's often one or several BWC tests will fail in CI when PR is created for 2.x codeline. If same tests re-ran again that will most likely pass. That adding lots of headache when you work with PR or plugin got built in distribution CI.

We do have 120+ bwc tests for 2.x codeline due to requirements of being backward compatible with all the versions from same major release. Error can be due to racing conditions on the test runner, or maybe some corner case in the test setup logic that with high number of runs will appear with higher probability.

How can one reproduce the bug?

Submit a PR for 2.x branch. For sample runs you can check some of the recent PRs:
https://github.com/opensearch-project/neural-search/actions/runs/11708689000/job/32611076434?pr=976

Do you have any additional context?

With main/3.x PRs it almost never happens, my guess its due to less combinations of versions - for 3.x we need to run only one latest 2.x.

@martin-gaievski martin-gaievski added bug Something isn't working untriaged good first issue Good for newcomers labels Nov 8, 2024
@dreyarlaxus
Copy link

can you assign this issue for me??

@martin-gaievski
Copy link
Member Author

@dreyarlaxus sure, feel free to work on this one. Let me know when you're ready with PR and reviews

@martin-gaievski
Copy link
Member Author

@dreyarlaxus you can start checking current 2.x, we have merged PR #983, so now 2.x pointing to the relevant branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Infrastructure
Projects
Status: 2.19.0
Development

No branches or pull requests

3 participants