Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flaky test: testReduceWithConcurrentSegmentSearch_whenMultipleCollectorsMatchedDocs_thenSuccessful #819

Closed
chishui opened this issue Jul 4, 2024 · 2 comments · Fixed by #984
Assignees
Labels

Comments

@chishui
Copy link
Contributor

chishui commented Jul 4, 2024

What is the bug?

testReduceWithConcurrentSegmentSearch_whenMultipleCollectorsMatchedDocs_thenSuccessful failed in gradle check: https://github.com/opensearch-project/neural-search/actions/runs/9788202904/job/27025892009?pr=769

org.opensearch.neuralsearch.search.query.HybridCollectorManagerTests > testReduceWithConcurrentSegmentSearch_whenMultipleCollectorsMatchedDocs_thenSuccessful FAILED
    java.lang.IllegalArgumentException: cannot merge top docs because it does not have enough elements
        at __randomizedtesting.SeedInfo.seed([8305B866B5D072CE:EAE289E17B23685E]:0)
        at org.opensearch.neuralsearch.search.query.HybridQueryScoreDocsMerger.merge(HybridQueryScoreDocsMerger.java:39)
        at org.opensearch.neuralsearch.search.query.TopDocsMerger.merge(TopDocsMerger.java:52)
        at org.opensearch.neuralsearch.search.query.HybridCollectorManager.reduceCollectorResults(HybridCollectorManager.java:241)
        at org.opensearch.neuralsearch.search.query.HybridCollectorManager.lambda$reduce$0(HybridCollectorManager.java:135)
        at org.opensearch.neuralsearch.search.query.HybridCollectorManager.lambda$reduceSearchResults$7(HybridCollectorManager.java:254)
        at org.opensearch.neuralsearch.search.query.HybridCollectorManagerTests.testReduceWithConcurrentSegmentSearch_whenMultipleCollectorsMatchedDocs_thenSuccessful(HybridCollectorManagerTests.java:412)
REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.neuralsearch.search.query.HybridCollectorManagerTests.testReduceWithConcurrentSegmentSearch_whenMultipleCollectorsMatchedDocs_thenSuccessful" -Dtests.seed=8305B866B5D072CE -Dtests.security.manager=false -Dtests.locale=af-ZA -Dtests.timezone=Europe/Uzhgorod -Druntime.java=11

How can one reproduce the bug?

It can be reproduced locally with command

./gradlew ':test' --tests "org.opensearch.neuralsearch.search.query.HybridCollectorManagerTests.testReduceWithConcurrentSegmentSearch_whenMultipleCollectorsMatchedDocs_thenSuccessful" -Dtests.seed=8305B866B5D072CE -Dtests.security.manager=false -Dtests.locale=af-ZA -Dtests.timezone=Europe/Uzhgorod

However, if remove the -Dtests.seed=8305B866B5D072CE, the test will pass.

What is the expected behavior?

The UT will pass with or without seed.

What is your host/environment?

linux/macos

Do you have any screenshots?

N/A

Do you have any additional context?

N/A

@chishui chishui added bug Something isn't working untriaged labels Jul 4, 2024
@chishui
Copy link
Contributor Author

chishui commented Jul 4, 2024

@martin-gaievski could you take a look?

@dblock
Copy link
Member

dblock commented Jul 22, 2024

[Catch All Triage w/ 1, 2, 3]

@dblock dblock removed the untriaged label Jul 22, 2024
@naveentatikonda naveentatikonda added the good first issue Good for newcomers label Sep 18, 2024
@jmazanec15 jmazanec15 added flaky-test and removed bug Something isn't working labels Oct 2, 2024
@minalsha minalsha removed their assignment Oct 16, 2024
@owaiskazi19 owaiskazi19 self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants