Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow method parameter override for training based indices #2246

Open
jmazanec15 opened this issue Nov 5, 2024 · 0 comments
Open

Allow method parameter override for training based indices #2246

jmazanec15 opened this issue Nov 5, 2024 · 0 comments
Labels
Enhancements Increases software capabilities beyond original client specifications v2.19.0

Comments

@jmazanec15
Copy link
Member

Description

From mode/disk-based feature, we introduced concept of mode and compression level that will dynamically set default resolution. For indices created directly from the method (i.e. mapping) we allow users to override parameters if they want.

However, for training, we added the mode and compression, but made them mutually exclusive with method. See: https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/plugin/rest/RestTrainModelHandler.java#L138-L139. We need to remove this and allow method overriding to provide a consistent ux experience across the plugin.

@jmazanec15 jmazanec15 added the Enhancements Increases software capabilities beyond original client specifications label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications v2.19.0
Projects
Status: Backlog (Hot)
Development

No branches or pull requests

1 participant