Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] re-add recent datasets #8814

Open
kavilla opened this issue Nov 5, 2024 · 0 comments
Open

[Discover] re-add recent datasets #8814

kavilla opened this issue Nov 5, 2024 · 0 comments
Labels
discover for discover reinvent discover-next enhancement New feature or request workspace

Comments

@kavilla
Copy link
Member

kavilla commented Nov 5, 2024

Description

Recent datasets was remove apart of:
#8816

This is because without workspaces enabled this fine but with it enabled then recent datasets was persisting across workspaces that potentially dont have the datasource available that the dataset is referencing.

The original fix we wanted to do was to save datasets with workspace id in session storage. To give users the ability to switch workspaces and have access to the previous visit of this workspace and recent datasets.

However, when investigating: the workspace is apart of core start application but dataset service is apart of a service that is apart of the setup lifecycle.

The second path could be storing the workspace in the dataset meta information. This will help with another issue as shared URLs currently take you out of a workspace. So if we add this to the dataset meta information we could recreate the dataset within workspace context. While also persisting the dataset in a specific workspace recents datasets. But the work wouldn't be large but it wouldn't necessarily small. Since the data plugin pretty much has to be enabled for the application to do anything but workspaces isn't as required (although it's a really sick feature).

The feature work should avoid placing it in a way that the data plugin is now a dependency of the workspaces service

@kavilla kavilla added bug Something isn't working untriaged labels Nov 5, 2024
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Nov 5, 2024
With workspaces disabled, recent datasets works fine.
However the dataset service does not have the concept of workspaces yet so instead of adding a new
feature we are opting for recent datasets not yielding any results. The dataset selector already
handles displaying or not if no recent datasets.

Follow up issue:
opensearch-project#8814

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla changed the title [BUG][Discover] recent datasets re-add [BUG][Discover] re-add recent datasets Nov 5, 2024
@kavilla kavilla added enhancement New feature or request discover for discover reinvent workspace discover-next and removed bug Something isn't working untriaged labels Nov 5, 2024
@kavilla kavilla changed the title [BUG][Discover] re-add recent datasets [Discover] re-add recent datasets Nov 6, 2024
ashwin-pc pushed a commit that referenced this issue Nov 6, 2024
With workspaces disabled, recent datasets works fine.
However the dataset service does not have the concept of workspaces yet so instead of adding a new
feature we are opting for recent datasets not yielding any results. The dataset selector already
handles displaying or not if no recent datasets.

Follow up issue:
#8814

Signed-off-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Nov 6, 2024
With workspaces disabled, recent datasets works fine.
However the dataset service does not have the concept of workspaces yet so instead of adding a new
feature we are opting for recent datasets not yielding any results. The dataset selector already
handles displaying or not if no recent datasets.

Follow up issue:
#8814

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 4f6b287)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this issue Nov 8, 2024
With workspaces disabled, recent datasets works fine.
However the dataset service does not have the concept of workspaces yet so instead of adding a new
feature we are opting for recent datasets not yielding any results. The dataset selector already
handles displaying or not if no recent datasets.

Follow up issue:
#8814


(cherry picked from commit 4f6b287)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover for discover reinvent discover-next enhancement New feature or request workspace
Projects
None yet
Development

No branches or pull requests

1 participant