@@ -24,8 +24,7 @@ In the majority of cases, new releases do not cause issues
2424so pinning simply forces users to workaround overly strict pins[ ^ 1 ]
2525(which can be done, see
2626[ working around incorrectly set pins] [ working-around-incorrectly-set-pins ] ).
27- The tradeoff with this approach is
28- This does run the risk that,
27+ The tradeoff with this approach is that you run the risk that,
2928if a dependency releases a breaking change,
3029the function provided by our package may break too.
3130
@@ -128,12 +127,12 @@ Finally, we also check the installation of the locked versions of the package,
128127i.e. installation with ` pip install 'gcages[locked]' ` .
129128These tests give us the greatest coverage of Python versions and operating systems
130129and help alert us to places where users may face issues.
131- Having said that, these tests do require 30 separate CI runs ,
130+ Having said that, these tests do require 30 separate jobs ,
132131which is why we don't run them in CI.
133132
134133Through this combination of CI testing and installation testing,
135134we get a pretty good coverage of the different ways in which our package can be used.
136135It is not perfect, largely because the combinatorics don't allow for testing everything.
137136If we find a particular, key, use case failing often,
138137then we would happily discuss whether this should be included in the CI too,
139- to catch issues earlier than at user time .
138+ to catch issues in advance of use .
0 commit comments