Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkey Ministry Of Interior Terrorist Wanted List #108

Closed
1 task done
Ketoch opened this issue Mar 12, 2024 · 4 comments · Fixed by opensanctions/opensanctions#665
Closed
1 task done

Turkey Ministry Of Interior Terrorist Wanted List #108

Ketoch opened this issue Mar 12, 2024 · 4 comments · Fixed by opensanctions/opensanctions#665

Comments

@Ketoch
Copy link

Ketoch commented Mar 12, 2024

Data URL

https://en.terorarananlar.pol.tr/tarananlar

Publisher

The Ministry Of Interior

Publisher country/territory code

No response

Type of data

Crime/Wanted/Suspected (Persons suspected or convicted of crimes and listed by official law enforcement)

Coverage region

region:Global

Can you tell us more?

No response

This is a suggestion or request

  • I understand.
@Ketoch Ketoch added the proposed This suggestion has not yet been accepted label Mar 12, 2024
@pudo pudo added crime-list difficulty:1 region:Europe and removed proposed This suggestion has not yet been accepted region:Global labels Mar 13, 2024
@pudo
Copy link
Member

pudo commented Mar 13, 2024

I wonder if this is behind a crawl protecting CDN; if so we'd need to manually capture it down.

@Ketoch
Copy link
Author

Ketoch commented Mar 15, 2024

I don't know exactly, but it looks like it is so

@fjuniorr fjuniorr self-assigned this Mar 15, 2024
@fjuniorr
Copy link

I've managed to manually get the data with:

curl 'https://www.terorarananlar.pol.tr/ISAYWebPart/TArananlar/GetTerorleArananlarList' \
  -X 'POST' \
  -H 'Content-Length: 0' \
  -H 'Content-Type: application/json'

However when trying to replicate the call with python requests I'm getting a UNSAFE_LEGACY_RENEGOTIATION_DISABLED error

2024-03-15 22:07:01 [info     ] Running dataset                [tr_wanted] data_path=datasets/tr_wanted data_time=2024-03-15T22:07:00 dataset=tr_wanted
2024-03-15 22:07:02 [error    ] HTTPSConnectionPool(host='www.terorarananlar.pol.tr', port=443): Max retries exceeded with url: /ISAYWebPart/TArananlar/GetTerorleArananlarList (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:992)'))) [tr_wanted] dataset=tr_wanted url=https://www.terorarananlar.pol.tr/ISAYWebPart/TArananlar/GetTerorleArananlarList

From urllib3/urllib3#2653 I learned that apparently this is what happens with OpenSSL 3.0 when connecting to legacy websites that disable renegotiation without signalling it correctly.

Is saving a local copy of the data in the repo such as in lt_illegal_websites advisable or best to use a workaround such as urllib3/urllib3#2653 (comment)?

@jbothma
Copy link
Contributor

jbothma commented Mar 18, 2024

yeah I think it's fine to enable the unsafe negotiation strategy, on the basis that we have another sanctions list that is http.

I'll notify them of the issue and ask that they look into upgrading.

Could you also add something like

if datetime.now > 2024-09-15:
    context.log.warn("Check if the SSL renegotiation strategy is still needed")

in the crawl() function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants