Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vertical diagrams #34

Open
timgdavies opened this issue Jun 8, 2020 · 1 comment
Open

Support for vertical diagrams #34

timgdavies opened this issue Jun 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@timgdavies
Copy link
Contributor

The visual language rules allow for horizontal and vertical diagrams.

Is it possible to implement a simple switch to choose between these layout options?

@stevenday
Copy link
Contributor

I took a quick look at this today, there's a simple switch in terms of the underlying options we give to dagre-d3, but doing so breaks the offset paths we use to draw ownership & control separately. Specifically the offset doesn't work any more, so we just get a single line instead of two visible.

Technically, it seems like there's some divide-by-zero issue, either in code which turns our SVG path into a bezier curve, or in the code that then offsets the curve.

The solution to this seems non-trivial, I think it's basically because dagre-d3 doesn't draw continuous curves, they have little straight bits coming out of the nodes. I'm not sure why this isn't a problem on horizontal layouts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants