Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many fields required to render a node #184

Open
kd-ods opened this issue Dec 5, 2024 · 0 comments · May be fixed by #175
Open

Too many fields required to render a node #184

kd-ods opened this issue Dec 5, 2024 · 0 comments · May be fixed by #175
Assignees

Comments

@kd-ods
Copy link
Collaborator

kd-ods commented Dec 5, 2024

Bug description

In the spec we say that the minimum fields required to render an entity node are:

  • recordType is “entity”
  • if recordStatus exists, it is not “closed”

And the equivalent for person nodes.

But in the demo, more fields than this have to be included.

Steps to reproduce

  1. Paste the following into the tool and click 'Draw'
[
  {
    "statementDate": "2019-01-20",
    "recordType": "entity",
    "recordDetails": {
      "entityType": {}
    }
  }
]
  1. Notice that an unknown entity node is rendered.

  2. Remove any one of the fields and try to redraw .

For person nodes, this is currently the minimal json that renders a node:

[
  {
    "statementDate": "2019-01-20",
    "recordType": "person"
  }
]

Expected behaviour

Ideally the following should render a node:

[
  {
    "recordType": "entity"
  }
]

And the equivalent for "person".

If making that work causes too many knock-on problems at this stage, we can change the spec.

@codemacabre codemacabre self-assigned this Dec 5, 2024
@codemacabre codemacabre moved this from Todo to In Review in Visualisation 2024 Sprint 2 of 2 Dec 9, 2024
@codemacabre codemacabre linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants