We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the spec we say that the minimum fields required to render an entity node are:
recordType
recordStatus
And the equivalent for person nodes.
But in the demo, more fields than this have to be included.
[ { "statementDate": "2019-01-20", "recordType": "entity", "recordDetails": { "entityType": {} } } ]
Notice that an unknown entity node is rendered.
Remove any one of the fields and try to redraw .
For person nodes, this is currently the minimal json that renders a node:
[ { "statementDate": "2019-01-20", "recordType": "person" } ]
Ideally the following should render a node:
[ { "recordType": "entity" } ]
And the equivalent for "person".
If making that work causes too many knock-on problems at this stage, we can change the spec.
The text was updated successfully, but these errors were encountered:
codemacabre
Successfully merging a pull request may close this issue.
Bug description
In the spec we say that the minimum fields required to render an entity node are:
recordType
is “entity”recordStatus
exists, it is not “closed”And the equivalent for person nodes.
But in the demo, more fields than this have to be included.
Steps to reproduce
Notice that an unknown entity node is rendered.
Remove any one of the fields and try to redraw .
For person nodes, this is currently the minimal json that renders a node:
Expected behaviour
Ideally the following should render a node:
And the equivalent for "person".
If making that work causes too many knock-on problems at this stage, we can change the spec.
The text was updated successfully, but these errors were encountered: