Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand missing next.config error message #84

Closed
wants to merge 2 commits into from

Conversation

shashankboosi
Copy link
Contributor

@shashankboosi shashankboosi commented Oct 10, 2024

Fixes #82

Found out that next dev can run the a Next.js app without next.config but if we are using the adapter we throw an error if we don't find the config

  1. So added a detailed error to point towards adding the next.config to run the application.
  2. Updated wrangler to it's latest version
  3. Also added the vercel blog starter into the examples which is what I used to debug the issue mentioned

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: f045531

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@84

commit: f045531

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PR contains quite a fex unwanted changes!

Could you please also add a patch changeset (see the automated comment on the PR).

Thanks a lot

@vicb
Copy link
Contributor

vicb commented Oct 10, 2024

OOps, I should have read the PR description.

Would you mind splitting 1, 2, and 3 into different PRs?

Thanks!

@shashankboosi
Copy link
Contributor Author

@vicb Will create different PRs, should I add patch changeset for all the PRs?

@vicb
Copy link
Contributor

vicb commented Oct 10, 2024

Thanks!

should I add patch changeset for all the PRs?

I would say only the error message fix.
It's not the biggest change but it will be very valuable to users.

@shashankboosi
Copy link
Contributor Author

I will close this and open separate PRs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Not in a Next.js app project
2 participants