Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bug and feature templates #124

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add bug and feature templates #124

merged 1 commit into from
Nov 7, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 5, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ed8d3a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Nov 5, 2024
Closed
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 5, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@124

commit: ed8d3a5

petebacondarwin
petebacondarwin approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion and a couple of comments.

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.md Show resolved Hide resolved
@vicb vicb force-pushed the templates branch 2 times, most recently from d3b292f to 44b9865 Compare November 7, 2024 09:59
@vicb vicb force-pushed the templates branch 2 times, most recently from 555187f to 3d04ef5 Compare November 7, 2024 10:06
dario-piotrowicz
dario-piotrowicz approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

I think using headings instead of bolded text would be nicer but it's also pretty minor

.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
@vicb vicb mentioned this pull request Nov 7, 2024
Closed
@vicb
Copy link
Contributor Author

vicb commented Nov 7, 2024

Thanks for the valuable feedback @dario-piotrowicz and @petebacondarwin.
I have integrated most of it and created #127 to further improve later.

@vicb vicb merged commit 4254f00 into main Nov 7, 2024
7 checks passed
@vicb vicb deleted the templates branch November 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @petebacondarwin @dario-piotrowicz