feat: use the cache api if there is no kv cache available #136
Conversation
🦋 Changeset detectedLatest commit: 5cd4724 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
james-elicx
requested review from
petebacondarwin,
vicb and
dario-piotrowicz
|
|
||
| export function getCacheStore() { | ||
| const kvName = process.env.__OPENNEXT_KV_BINDING_NAME; | ||
| if (process.env[kvName]) { |
There was a problem hiding this comment.
I think we should remove the bindings from process.env and we should move to getCloudflareContext - could be done in a follow up PR, in which case it would be nice to add a // TODO: ...
There was a problem hiding this comment.
getCloudflareContext is async at the moment because of local dev, so it won't work here unless we move the retrieving of the cache to be part of an interaction with the cache instead of when the cache handler is instantiated.
There was a problem hiding this comment.
yep, you can create a TODO/issue for that. thanks.
packages/cloudflare/src/cli/templates/cache-handler/cache-store.ts
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| export type CacheStore = { | ||
| get: (key: string) => Promise<CacheEntry | null>; |
There was a problem hiding this comment.
They are - the return type is a promise
| } | ||
| } | ||
|
|
||
| class CacheAPIStore implements CacheStore { |
There was a problem hiding this comment.
@petebacondarwin @dario-piotrowicz I'm not familiar the cf cache API, do you have thoughts about this class?
With my limited understanding of the cache API, I'm not sure if we should use it for the fetch cache (as long as the cache headers are set correctly on the fetch call).
I'm also wondering about custom keys.
james-elicx
force-pushed
the
james/cache-api-default
branch
from
d12a709
to
5cd4724
Compare
Changes
resolves #134