Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused optional parameter from _yk_piv_ctrl #572

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

renatav
Copy link
Collaborator

@renatav renatav commented Dec 12, 2024

Description (e.g. "Related to ...", etc.)

We do not currently, and have never needed to pass a public key pem to the piv context manager.
The code that is invoked if this pem is passed does not work, but the general idea is also not robust enough (see comments in #515).
Since we are not using this, I think that we should just remove this code. We'll implement it if a need for it arises.
Also found and fixed a minor setup_test_yubikey issue

Closes #515

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@renatav renatav force-pushed the renatav/remove-unused-pub-key-yubikey branch 3 times, most recently from 7171e07 to 30c094a Compare December 12, 2024 21:34
@renatav renatav force-pushed the renatav/remove-unused-pub-key-yubikey branch from 30c094a to 77dd57c Compare December 12, 2024 21:45
@renatav renatav changed the title Rremove unused optional parameter from _yk_piv_ctrl Remove unused optional parameter from _yk_piv_ctrl Dec 13, 2024
@renatav renatav marked this pull request as ready for review December 13, 2024 04:53
@renatav renatav requested a review from n-dusan December 13, 2024 04:58
@renatav renatav self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yubikey piv context manager does not yield if passed pub key matches
1 participant