Remove unused optional parameter from _yk_piv_ctrl #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
We do not currently, and have never needed to pass a public key pem to the piv context manager.
The code that is invoked if this pem is passed does not work, but the general idea is also not robust enough (see comments in #515).
Since we are not using this, I think that we should just remove this code. We'll implement it if a need for it arises.
Also found and fixed a minor
setup_test_yubikey
issueCloses #515
Code review checklist (for code reviewer to complete)