Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename client_id_scheme web-origin? #351

Open
Sakurann opened this issue Nov 28, 2024 · 3 comments
Open

rename client_id_scheme web-origin? #351

Sakurann opened this issue Nov 28, 2024 · 3 comments
Labels
discuss if we do this
Milestone
Final 1.0

Comments

@Sakurann
Copy link
Collaborator 

          Do we need to call out these can be web origins or native app origins?

Originally posted by @leecam in #337 (comment)

current agreement seems to be no need to differentiate but opening an issue just in case.
@Sakurann Sakurann mentioned this issue Nov 28, 2024
Merged
@Sakurann Sakurann added this to the Final 1.0 milestone Dec 5, 2024
@c2bo c2bo mentioned this issue Jan 21, 2025
Merged
@Sakurann Sakurann changed the title Do we need to call out these can be web origins or native app origins? rename client_id_scheme web-origin? Jan 21, 2025
@c2bo
Copy link
Member

c2bo commented Jan 21, 2025

If we agree to stick with one client id scheme (which seems to be the current direction), then we should probably rename to something like platform-origin. A native-app initiated flow doesn't really fit with web-origin imho (and neither would directly calling via some proximity flow with CTAP).

@Sakurann
Copy link
Collaborator Author

+1 to platform-origin

@timcappalli
Copy link
Member

How about just origin since it has a definition now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss if we do this
Projects
None yet
Milestone
Final 1.0
Development

No branches or pull requests
3 participants
@timcappalli @c2bo @Sakurann