Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data validation of baskets with empty t_ili_tid fails #957

Open
webrian opened this issue Sep 2, 2024 · 1 comment
Open

Data validation of baskets with empty t_ili_tid fails #957

webrian opened this issue Sep 2, 2024 · 1 comment
Labels

Comments

@webrian
Copy link
Contributor

webrian commented Sep 2, 2024

  • a database schema with three datasets, each of the dataset has one basket
  • since the import was done without --importBid the t_ili_tid column is empty, see the database table:

grafik

  • the baskets in the Model Baker Data Validator widget:

grafik

the basket validation fails with:

Traceback (most recent call last):
  File "C:\Users/bjsvwweb/AppData/Roaming/QGIS/QGIS3\profiles\INTEGRATION/python/plugins\QgisModelBaker\gui\validate.py", line 391, in _run
    self._validator_stdout(f"Run: {validator.command(True)}")
  File "C:\Users/bjsvwweb/AppData/Roaming/QGIS/QGIS3\profiles\INTEGRATION/python/plugins\QgisModelBaker\libs\modelbaker\iliwrapper\iliexecutable.py", line 99, in command
    args = self._args(hide_password)
  File "C:\Users/bjsvwweb/AppData/Roaming/QGIS/QGIS3\profiles\INTEGRATION/python/plugins\QgisModelBaker\libs\modelbaker\iliwrapper\ilivalidator.py", line 42, in _args
    args = super()._args(hide_password)
  File "C:\Users/bjsvwweb/AppData/Roaming/QGIS/QGIS3\profiles\INTEGRATION/python/plugins\QgisModelBaker\libs\modelbaker\iliwrapper\iliexecutable.py", line 80, in _args
    return get_ili2db_args(self.configuration, hide_password)
  File "C:\Users/bjsvwweb/AppData/Roaming/QGIS/QGIS3\profiles\INTEGRATION/python/plugins\QgisModelBaker\libs\modelbaker\iliwrapper\ili2dbargs.py", line 40, in get_ili2db_args
    return configuration.to_ili2db_args(db_args)
  File "C:\Users/bjsvwweb/AppData/Roaming/QGIS/QGIS3\profiles\INTEGRATION/python/plugins\QgisModelBaker\libs\modelbaker\iliwrapper\ili2dbconfig.py", line 451, in to_ili2db_args
    self.append_args(args, ["--baskets", ";".join(self.baskets)])
TypeError: sequence item 0: expected str instance, NoneType found
  • filling an id into the t_ili_id column:

grafik

the validation works!
It is the same issue in the export Wizard as well.

@signedav
Copy link
Member

signedav commented Sep 3, 2024

The bug here is that baskets without t_ili_tid are provided to the selection in the validator...

@signedav signedav added the bug label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants