Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cjk compliant font family #357

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Conversation

why-not-try-calmer
Copy link
Contributor

@why-not-try-calmer why-not-try-calmer commented Jul 14, 2023

This needs to be tested. I don't have access to the Chinese or Japanese translations.

Depends on #369.

@duke-nyuki
Copy link

@JinIgarashi
Copy link
Contributor

@why-not-try-calmer I tested with Noto Sans font locally after pulling ja/zh from transifex. It does not work unfortunately. Looks like have to specify font like Noto Sans JP as social plugin example shows.

I think only a way is to use custmisation feature of social card (insiders' version) to insert font family for each language markdown file as I commented in the following issue.

#355 (comment)

@why-not-try-calmer
Copy link
Contributor Author

@why-not-try-calmer I tested with Noto Sans font locally after pulling ja/zh from transifex. It does not work unfortunately. Looks like have to specify font like Noto Sans JP as social plugin example shows.

I think only a way is to use custmisation feature of social card (insiders' version) to insert font family for each language markdown file as I commented in the following issue.

#355 (comment)

Okay, will do, thanks

@why-not-try-calmer why-not-try-calmer marked this pull request as draft July 17, 2023 15:31
@why-not-try-calmer
Copy link
Contributor Author

@JinIgarashi By the way do you have a link to the page hosting the badly rendered social card?

@JinIgarashi
Copy link
Contributor

@why-not-try-calmer I don't have it. But you can get link of social card from head tags in each html from developer tool of Chrome. Change any language code to ja/zh, you can get bad social code.

@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Jul 18, 2023

@why-not-try-calmer I don't have it. But you can get link of social card from head tags in each html from developer tool of Chrome. Change any language code to ja/zh, you can get bad social code.

Devtools hum... But in what circumstances is the regular user going to run into the issue? Sorry I am not super familiar with social cards but I am interested in the context in which this issue occurs.

@JinIgarashi
Copy link
Contributor

@why-not-try-calmer For example, when you paste a link of website to social media like twitter or Facebook, LinkedIn, etc, normally social card image and site name and description will be shown if appropriate meta tags exists in html head.

this is important for readers to know what the link is without visiting website. Also, in terms of SEO, search engines like google can collect information from those metadata.

If you want to advertise QField more through the internet, you should consider adding appropriate meta tags including social card.

@why-not-try-calmer
Copy link
Contributor Author

Thanks, I'll come up with something.

@why-not-try-calmer why-not-try-calmer marked this pull request as ready for review August 24, 2023 12:58
@why-not-try-calmer
Copy link
Contributor Author

Implemented suggestion from squidfunk/mkdocs-material#5704 (reply in thread).

@why-not-try-calmer why-not-try-calmer force-pushed the QF-2930_cjk-compliant-fonts branch 2 times, most recently from fd7e078 to 11fd636 Compare August 24, 2023 13:30
@why-not-try-calmer why-not-try-calmer force-pushed the QF-2930_cjk-compliant-fonts branch from d005e0f to fa71a1e Compare September 15, 2023 16:56
@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Sep 15, 2023

This produces:
image
as recommended at squidfunk/mkdocs-material#5704 (reply in thread).

@JinIgarashi Ok for you?
@m-kuhn can we merge?

@why-not-try-calmer why-not-try-calmer enabled auto-merge (squash) September 15, 2023 17:12
@JinIgarashi
Copy link
Contributor

@why-not-try-calmer thanks, looks good.

@why-not-try-calmer why-not-try-calmer merged commit 42baf65 into master Sep 16, 2023
1 check passed
@why-not-try-calmer why-not-try-calmer deleted the QF-2930_cjk-compliant-fonts branch September 16, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] font issue of og image in Chinese and Japanese language
4 participants