Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate optional tests #47

Open
dstenger opened this issue May 8, 2018 · 2 comments
Open

Reactivate optional tests #47

dstenger opened this issue May 8, 2018 · 2 comments

Comments

@dstenger
Copy link
Contributor

dstenger commented May 8, 2018

These were deactivated by #28.

#41, for example, asks for GetFeatureInfo tests which were removed.

@aaime
Copy link

aaime commented Jan 4, 2025

I'm stumbling into a problem which may be the same, but could also be related.

When running tests from the HTML forms, I can select getFeatureInfo and RESTful tests, and can confirm they are actually run:

image

However, the REST version of the test only comes with the capabilities URL:

image

and indeed the parameters are not exposed in the wmts-auto.xml, which I'm guessing it's used by the REST invocation:), but are instead hard-coded to "off":

      <ctl:call-test name="wmts:main">
        <ctl:with-param name="capabilities-url" select="$capabilities-url" />
        <ctl:with-param name="fail-early">off</ctl:with-param>
	    <ctl:with-param name="include-CommonOperations-tests">on</ctl:with-param>
	    <ctl:with-param name="include-GetCapabilities-tests">on</ctl:with-param>
	    <ctl:with-param name="include-GetTile-tests">on</ctl:with-param>
	    <ctl:with-param name="include-GetFeatureInfo-tests">off</ctl:with-param>
	    <ctl:with-param name="include-kvp-get-encoding">on</ctl:with-param>
	    <ctl:with-param name="include-restful-encoding">off</ctl:with-param>
	  </ctl:call-test>

I guess that exposing the parameter requires more than just adding variables in this file... is there documentation explaining how this is done?

@dstenger
Copy link
Contributor Author

dstenger commented Jan 6, 2025

Indeed, adding the parameters in wmts-auto.xml should activate the functionality in the REST interface.
E.g. activating GetFeatureInfo Tests via parameter:

...
  <ctl:test name="wmts:main-auto" type="Mandatory">
    <ctl:param name="capabilities-url" />
    <ctl:param name="include-GetFeatureInfo-tests"/>
...
    <ctl:code>
      <ctl:call-test name="wmts:main">
        <ctl:with-param name="capabilities-url" select="$capabilities-url" />
...
        <ctl:with-param name="include-GetFeatureInfo-tests" select="$include-GetFeatureInfo-tests"/>
...
	  </ctl:call-test>
	</ctl:code>
  </ctl:test>
...

However, there is more work to do if a pull request shall be created:

  • Update of documentation: overview.html, overview,xml
  • Update of test-run-props.xml
  • Update of TestRunArguments.java

@dstenger dstenger added this to CITE Jan 6, 2025
@github-project-automation github-project-automation bot moved this to To do in CITE Jan 6, 2025
@dstenger dstenger removed their assignment Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants