Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCS 2.0.1 compliance test (te2) has problem in wcs2:post-xml-req5 #119

Closed
greatzzk opened this issue Jun 1, 2023 · 13 comments
Closed

WCS 2.0.1 compliance test (te2) has problem in wcs2:post-xml-req5 #119

greatzzk opened this issue Jun 1, 2023 · 13 comments
Assignees

Comments

@greatzzk
Copy link

greatzzk commented Jun 1, 2023

request and failure msg is like:
image

but it works on my side with a proper response. It looks to me that the test fails to parse the returned multipart tiff
image

@greatzzk greatzzk changed the title WCS 2.0.1 compliance test has problem in wcs2:post-xml-req5 WCS 2.0.1 compliance test (te2) has problem in wcs2:post-xml-req5 Jun 1, 2023
@dstenger
Copy link
Contributor

dstenger commented Jun 2, 2023

Thank you for reporting.

There might be a connection to issue #55.

Is it possible to provide a test service instance so that we can analyze the TEAM Engine logging?

@dstenger
Copy link
Contributor

dstenger commented Jun 5, 2023

Full error message: Error in call to extension function {public org.w3c.dom.NodeList com.occamlab.te.TECore.request(org.w3c.dom.Document,java.lang.String) throws java.lang.Throwable}: Exception in extension function java.lang.RuntimeException: Parser {http://www.occamlab.com/te/parsers}HTTPParser threw an exception.

Indeed, it seems that the HTTPParser cannot handle the response of your service.
Thus, I label this issue as bug and the CITE developer team will take a closer look at this.

@bpross-52n
Copy link
Contributor

@greatzzk My findings are that the response has probably a syntax issue. According to this RFC, there needs to be an empty line after the header section of each (multi)-part. Example of a response from your server:

--wcs
Content-Type: text/xml
Content-ID: GML-Part
<?xml version="1.0" encoding="UTF-8"?>

I did some test with multipart libraries and they could read the response only after I manually added an empty line after the header section:

--wcs
Content-Type: text/xml
Content-ID: GML-Part

<?xml version="1.0" encoding="UTF-8"?>

@dstenger dstenger assigned greatzzk and unassigned bpross-52n Jul 13, 2023
@ghobona
Copy link
Contributor

ghobona commented Jul 13, 2023

@greatzzk Please let us know when you have fixed the issue on your server.

@greatzzk
Copy link
Author

greatzzk commented Jul 13, 2023

Thanks!! We will change accordingly and retest against TE2

@greatzzk
Copy link
Author

greatzzk commented Aug 2, 2023

@ghobona @bpross-52n
we updated our server to included the blank line as suggested, but te2 wcs2:post-xml-req5 still fails. could you take a look?
image

@dstenger dstenger assigned bpross-52n and unassigned greatzzk Aug 3, 2023
@dstenger
Copy link
Contributor

dstenger commented Aug 3, 2023

Thank you reporting back. We will take a look at your results.

@bpross-52n
Copy link
Contributor

@greatzzk My tests show that there is still no new line after the header section of the second (inline tiff) part. That is the reason the parsing still fails.

@greatzzk
Copy link
Author

greatzzk commented Aug 4, 2023

@bpross-52n thanks for analyzing the problem and apparently we have added that blank line as showing in the screenshot above.
how do we fix our server? or
will you debug into your test code?

@bpross-52n
Copy link
Contributor

@greatzzk Yes, the parser can now read the first part (GML), but the second part still looks like this:

Content-Type: image/tiff
Content-Description: coverage data
Content-Transfer-Encoding: binary
Content-ID: mynetcdf.tif
Content-Disposition: inline
II*

when it should look like this:

Content-Type: image/tiff
Content-Description: coverage data
Content-Transfer-Encoding: binary
Content-ID: mynetcdf.tif
Content-Disposition: inline

II*

@greatzzk
Copy link
Author

greatzzk commented Aug 7, 2023

@bpross-52n thanks. we will fix accordingly and retest here

@greatzzk
Copy link
Author

it passed all wcs 2.0.1 post-xml test on TE2 now. We added a blank line between each header and body inside the multi-part response.

@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Done in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants