refactor: integrating off-dart 1.30.1 #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `background_task_details.dart`: minor refactoring * `background_task_image.dart`: minor refactoring * `background_task_refresh_later.dart`: minor refactoring * `country_selector.dart`: minor refactoring * `new_product_page.dart`: minor refactoring * `ocr_packaging_helper.dart`: minor refactoring * `offline_data_page.dart`: now using an explicit api version * `ordered_nutrients_cache.dart`: minor refactoring * `paged_search_product_query.dart`: now using an explicit api version * `paged_to_be_completed_product_query.dart`: now using an explicit api version * `Podfile.lock`: wtf * `product_image_data.dart`: minor refactoring * `product_list.dart`: minor refactoring * `product_list_import_export.dart`: now using an explicit api version * `product_list_page.dart`: now using an explicit api version * `product_query.dart`: explicit api version * `product_query_page.dart`: minor refactoring * `product_refresher.dart`: now using an explicit api version * `products_preload_helper.dart`: now using an explicit api version * `app/pubspec.lock`: wtf * `smooth_app/pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart version to 1.30.1 * `up_to_date_changes.dart`: minor refactoring
github-actions
bot
added
dependencies
🤗 Onboarding
Codecov Report
@@ Coverage Diff @@
## develop #3471 +/- ##
===========================================
+ Coverage 11.18% 11.23% +0.05%
===========================================
Files 261 261
Lines 12668 12670 +2
===========================================
+ Hits 1417 1424 +7
+ Misses 11251 11246 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Impacted file: * `user_preferences_account.dart`: now logging error and displaying nothing if cannot count, and optimized the code
M123-dev
approved these changes
Dec 26, 2022
There was a problem hiding this comment.
Looks good, thanks @monsieurtanuki just one little comment to consider
| @@ -1,3 +1,5 @@ | |||
| // ignore_for_file: deprecated_member_use | |||
There was a problem hiding this comment.
What are we ignoring here, please, at least add a todo to handle this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
background_task_details.dart: minor refactoringbackground_task_image.dart: minor refactoringbackground_task_refresh_later.dart: minor refactoringcountry_selector.dart: minor refactoringnew_product_page.dart: minor refactoringocr_packaging_helper.dart: minor refactoringoffline_data_page.dart: now using an explicit api versionordered_nutrients_cache.dart: minor refactoringpaged_search_product_query.dart: now using an explicit api versionpaged_to_be_completed_product_query.dart: now using an explicit api versionPodfile.lock: wtfproduct_image_data.dart: minor refactoringproduct_list.dart: minor refactoringproduct_list_import_export.dart: now using an explicit api versionproduct_list_page.dart: now using an explicit api versionproduct_query.dart: explicit api versionproduct_query_page.dart: minor refactoringproduct_refresher.dart: now using an explicit api versionproducts_preload_helper.dart: now using an explicit api versionapp/pubspec.lock: wtfsmooth_app/pubspec.lock: wtfpubspec.yaml: upgraded off-dart version to 1.30.1up_to_date_changes.dart: minor refactoringWhat
api_versionmandatory in off-dart 2.0.0, for more clarity.