Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1161 - the edit product page now calls the edit nutrition page #1167

Merged

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • edit_product_page.dart: now calling the edit nutrition page; now pops a "changed?" bool; refactored the ListTiles
  • knowledge_panels_builder.dart: refactored with the new cache call
  • new_product_page.dart: now refreshes the page after edits
  • ordered_nutrients_cache.dart: refactored as a black box regarding the get/download combo

What

  • description of the PR

Screenshot

Simulator Screen Shot - iPhone 8 Plus - 2022-02-28 at 19 38 55

Part of

…utrition page

Impacted files:
* `edit_product_page.dart`: now calling the edit nutrition page; now pops a "changed?" bool; refactored the `ListTile`s
* `knowledge_panels_builder.dart`: refactored with the new cache call
* `new_product_page.dart`: now refreshes the page after edits
* `ordered_nutrients_cache.dart`: refactored as a black box regarding the get/download combo
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner February 28, 2022 18:39
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually approved 👍

@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - Nutrition input labels Mar 3, 2022
@monsieurtanuki monsieurtanuki merged commit dda3be8 into openfoodfacts:develop Mar 3, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your visual check!

@monsieurtanuki monsieurtanuki linked an issue Mar 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Nutrition input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a full edit mode
2 participants