Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the category picker within the product page #944

Closed
1 of 5 tasks
Tracked by #1265 ...
teolemon opened this issue Jan 13, 2022 · 5 comments
Closed
1 of 5 tasks
Tracked by #1265 ...

Integrate the category picker within the product page #944

teolemon opened this issue Jan 13, 2022 · 5 comments
Assignees

Comments

@teolemon
Copy link
Member

teolemon commented Jan 13, 2022

What

  • Integrate the category picker within the product page
    • Bind it to the "Add missing product category" button
    • Bind it to the server side API for category streaming (Read only)
    • Actually send edits

Mockup

image

Code pointers

Part of

@teolemon teolemon added category explorer 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. labels Jan 13, 2022
@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 13, 2022 via email

@teolemon
Copy link
Member Author

Those questions are asked if and only if we are able to predict a category.
Otherwise, the category picker will be the only option.
Additionally, it's useful to adjust the category (in case of wrong prediction, error, or because a human is able to deep dive)

@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 13, 2022 via email

@teolemon teolemon moved this to Todo in Road to Scores Feb 11, 2022
@monsieurtanuki monsieurtanuki self-assigned this Feb 16, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 17, 2022
…ry product button

New files:
* `category_cache.dart`: Cache where we download and store category data.
* `category_picker_page.dart`: Category picker page.
* `product_refresher.dart`: Refreshes a product on the BE then on the local database.

Impacted files:
* `new_product_page.dart`: now the temporary button opens the category picker page.
* `nutrition_page_loaded.dart`: refactored using new class `ProductRefresher`.
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 18, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 18, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 18, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 18, 2022
monsieurtanuki added a commit that referenced this issue Feb 20, 2022
…tton (#1148)

New files:
* `category_cache.dart`: Cache where we download and store category data.
* `category_picker_page.dart`: Category picker page.
* `product_refresher.dart`: Refreshes a product on the BE then on the local database.

Impacted files:
*  `label.yml` - Co-authored-by @teolemon
* `new_product_page.dart`: now the temporary button opens the category picker page.
* `nutrition_page_loaded.dart`: refactored using new class `ProductRefresher`.
@teolemon
Copy link
Member Author

It's already implemented, but the button is disabled, we should link it to the current experimental view
image

@teolemon
Copy link
Member Author

fixed

Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 25, 2022
Repository owner moved this from Todo to Done in Road to Scores Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants