Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the category filter in product query page #2715

Closed
monsieurtanuki opened this issue Aug 2, 2022 · 5 comments · Fixed by #2718
Closed

Remove the category filter in product query page #2715

monsieurtanuki opened this issue Aug 2, 2022 · 5 comments · Fixed by #2718
Assignees

Comments

@monsieurtanuki
Copy link
Contributor

Problem

On top right of the product query page, there's a filter button.
This filter opens the list of the current page product's categories, and let the user decide which category to restrict the visible products to.

My complaints:

  • I suspect it was just a "what if?" test
  • The interface hasn't changed from the very start and the UX stinks
  • I don't think it's in Figma
  • I don't think it's used by "real" users
  • this slows down the display of the product pages (as we need to parse all products first, in order to know all the categories to put in the filter)
  • I want to put a "country" or "world" icon on the same spot

Proposed solutions

  • Remove that filter if it's not used
  • Put stats on the use of that filter to checked how and if it is used
  • Load the filter async'ly

Screenshot

Capture d’écran 2022-08-02 à 18 52 05

Then I click on "Filter" on top right
Capture d’écran 2022-08-02 à 18 54 53

Then I click on "All" and its expand button
Capture d’écran 2022-08-02 à 18 55 09

Then I select a category
Capture d’écran 2022-08-02 à 18 55 31

Then I click on "Apply"

@teolemon
Copy link
Member

teolemon commented Aug 2, 2022

@teolemon
Copy link
Member

teolemon commented Aug 2, 2022

It solves extend to world, it solves category filtering, and much more

@monsieurtanuki
Copy link
Contributor Author

That's teolemon in Amonbofis mode.

@monsieurtanuki
Copy link
Contributor Author

I take that as a "get rid of the filter" order, and I thank you for that.

I keep working on the "world search" because I'm almost done and the use case is a bit different, as it deals with the "Come on, everybody knows what a 'rårörda lingon' is! Let's try the world instead of that ignorant country" case.

@monsieurtanuki monsieurtanuki self-assigned this Aug 2, 2022
@monsieurtanuki
Copy link
Contributor Author

That's a game changer: the (cached) results are now instant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants