Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions for linked panels #1709

Closed
teolemon opened this issue Apr 29, 2022 · 10 comments
Closed

Handle exceptions for linked panels #1709

teolemon opened this issue Apr 29, 2022 · 10 comments

Comments

@teolemon
Copy link
Member

teolemon commented Apr 29, 2022

What

Part of

Video

linked-panels.mp4
@teolemon
Copy link
Member Author

teolemon commented May 5, 2022

@PrimaelQuemerais would you have time to tackle that one ?

@teolemon
Copy link
Member Author

teolemon commented May 5, 2022

or @M123-dev (that might be easier for you)

@stephanegigandet
Copy link
Contributor

Well it's working on the website: https://fr.openfoodfacts.org/produit/42114321/mullermilch-schoko-muller#panel_additives

@cli1005 cli1005 self-assigned this May 9, 2022
@cli1005
Copy link
Contributor

cli1005 commented May 9, 2022

The additives panel does not have titleElement.title, is that normal?
https://world.openfoodfacts.org/product/42114321?fields=knowledge_panels
Capture d’écran 2022-05-09 à 11 06 39

I might replace it with an empty string in case of missing title to avoid meeting such kind of problem again , but adding titleElement.title to the additive panel might be necessary?

@cli1005 cli1005 moved this from Todo (ready 2 dev) to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 9, 2022
@monsieurtanuki
Copy link
Contributor

Probably related to #1791.

@cli1005
Copy link
Contributor

cli1005 commented May 9, 2022

Probably related to #1791.

Yes, this issue can be fixed by #1791, @teolemon, do we need to add missing titleElement.title in the additive panel on the "server side" (I mean JSON returned) ?

@teolemon
Copy link
Member Author

teolemon commented May 9, 2022

It would be interesting to understand which panel is at fault cc @stephanegigandet

@teolemon
Copy link
Member Author

teolemon commented May 9, 2022

ah too bad, I spoke too quickly, there's a JSON above

@stephanegigandet
Copy link
Contributor

Hi @cli1005 , the additives panel is an inline panel, which means we want to display its content. It does not have a title.

It is inside a panel group for additives, and the panel group has a title.

@cli1005
Copy link
Contributor

cli1005 commented May 9, 2022

@teolemon, we could close this issue, since the PR #1791 has been merged

@teolemon teolemon closed this as completed May 9, 2022
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 9, 2022
@cli1005 cli1005 removed their assignment May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants