Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The barcode field should be a string, not an integer #137

Open
stephanegigandet opened this issue Sep 7, 2022 · 5 comments · May be fixed by #244
Open

The barcode field should be a string, not an integer #137

stephanegigandet opened this issue Sep 7, 2022 · 5 comments · May be fixed by #244
Labels
🎯 P0

Comments

@stephanegigandet
Copy link

In Product Opener, barcodes are stored as strings (in the "code" field), not integers. One reason is that they can contain leading 0s. Internally, for the Producers platform, we also prefix barcodes with organization ids. (e.g. "org-something:[barcode]").

Related to #136
@stephanegigandet stephanegigandet mentioned this issue Sep 7, 2022
Merged
@jaivardhan-bhola
Copy link

can i work on this please?

@alexgarel
Copy link
Member

@jaivardhan-bhola sorry I didn't had the mention. Please do ! This would be really important to fix :-)

@jaivardhan-bhola
Copy link

So basically you need it in int or str?

@alexgarel
Copy link
Member

code must be string and not int.

@jaivardhan-bhola
Copy link

oki

@jaivardhan-bhola jaivardhan-bhola mentioned this issue Feb 2, 2023
Closed
jaivardhan-bhola added a commit to jaivardhan-bhola/openfoodfacts-events that referenced this issue Feb 2, 2023
@jaivardhan-bhola
fix: openfoodfacts#137
4e0a712
@jaivardhan-bhola jaivardhan-bhola mentioned this issue Feb 2, 2023
Closed
@alexgarel alexgarel added 🎯 P0 bug Something isn't working labels Apr 11, 2023
@florentleveque florentleveque linked a pull request Apr 17, 2023 that will close this issue
Open
@teolemon teolemon removed the bug Something isn't working label Oct 25, 2024
@teolemon teolemon linked a pull request Oct 25, 2024 that will close this issue
fix: The barcode field should be a string, not an integer - #137 #244
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎯 P0
Projects
👾 Community & Gamification
Status: No status
Milestone
No milestone
4 participants
@alexgarel @teolemon @stephanegigandet @jaivardhan-bhola