Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.3.3 #227

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Release 1.3.3 #227

merged 4 commits into from
Sep 15, 2021

Conversation

peterwvj
Copy link
Collaborator

Please check whether the CHANGELOG properly reflects recent changes

M123-dev
M123-dev reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more thing I would like to add before the release, can we wait for it

CHANGELOG.md Outdated Show resolved Hide resolved
monsieurtanuki
monsieurtanuki approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably merge and include #217 too.

@peterwvj
Copy link
Collaborator Author

We could probably merge and include #217 too.

@monsieurtanuki feel free to include that too. Once it is merged I'll update the CHANGELOG.

@peterwvj
Copy link
Collaborator Author

@M123-dev are you thinking of a particular PR you'd like to have merged? We could just release what we currently have. Publishing to pubdev is just a matter of issuing a single command and I think "small" releases are fine.

@peterwvj peterwvj merged commit c9f629b into master Sep 15, 2021
@peterwvj peterwvj deleted the peterwvj/release-1.3.3 branch September 15, 2021 19:52
@M123-dev
Copy link
Member

@peterwvj, all things from me are merged, but there are still some errors, am still investigating where they come from.

@peterwvj
Copy link
Collaborator Author

@M123-dev that's fine. I merged the changelog changes for now but I didn't publish anything. Let me know how things go

@M123-dev
Copy link
Member

@peterwvj

stephanegigandet on Slack:

FYI, we are moving openfoodfacts.net and there are currently issues that make the dart package tests fail.
Fixing in progress

The interesting thing is that the test pass on my machine, but not here

@monsieurtanuki
Copy link
Contributor

@peterwvj I've just merged #217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev left review comments

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

@PrimaelQuemerais PrimaelQuemerais Awaiting requested review from PrimaelQuemerais

@MohamedFBoussaid MohamedFBoussaid Awaiting requested review from MohamedFBoussaid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterwvj @M123-dev @monsieurtanuki