Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Multiple OpenFoodFactsLanguage enum occurrences in g files #1028

Open
M123-dev opened this issue Jan 24, 2025 · 1 comment
Open

Comments

@M123-dev
Copy link
Member

While having a look at openfoodfacts/smooth-app#6215 that multiple g files include the OpenFoodFactsLanguage enum.

It's far from a high priority, but it's wasted storage and bandwidth to have it so many times.

But we have to check if there is even a way to configure it not be included in all files.

https://github.com/search?q=repo%3Aopenfoodfacts%2Fopenfoodfacts-dart%20OpenFoodFactsLanguage.FINNISH&type=code

@M123-dev M123-dev changed the title Code Quality: Multiple OpenFoodFactsLanguage enums in g files Code Quality: Multiple OpenFoodFactsLanguage enum occurrences in g files Jan 24, 2025
@monsieurtanuki
Copy link
Contributor

Hi @M123-dev!
By definition we have limited control over generated files. We're even talking about private fields, so no off-dart user is likely to misuse them.
That said, if there's an easy and maintainable solution to generate less duplicate code, why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants