Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose username and password environment variables #140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aballet
Copy link
Contributor

@aballet aballet commented Jun 12, 2024

Description

This PR exposes the OPENFGA_DATASTORE_USERNAME and OPENFGA_DATASTORE_PASSWORD environment variables. They can be references directly in the values file, or through a secret. The username and password keys in the secret are also configurable. I took inspiration from Keycloak's way of accessing username and password from an existing secret.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@aballet aballet requested review from a team as code owners June 12, 2024 15:27
Copy link

linux-foundation-easycla bot commented Jun 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aballet / name: Adrien Ballet (247d4f0)
  • ✅ login: rhamzeh / name: Raghd Hamzeh (08f6672)

@aballet aballet force-pushed the expose-credentials-envvars branch from 8f60577 to 247d4f0 Compare June 12, 2024 15:33
@MisterTimn
Copy link

I made similar changes to our fork or the openfga chart and made a PR before actually checking this one that's been parked here for quite a while.
#163

Hoping to bump this PR for review by code owners and would also propose to make it so that uriSecret gets the same configurability with regards to key selection, perhaps consolide them into one secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants